Skip to content

Commit

Permalink
Fix typo causing patterns docs to remain visible on nimble.ni.dev/sto…
Browse files Browse the repository at this point in the history
…rybook (#1495)

# Pull Request

## 🤨 Rationale

After #1490 I noticed that the MDX file for the "patterns" doc section
that we intended to hide was still visible in the publicly hosted
https://nimble.ni.dev/storybook/?path=/docs/patterns-docs--docs

## 👩‍💻 Implementation

The filter was excluding "patterns/" but the MDX file was titled
"Patterns/". I made it lowercase to match the filter and the folder that
contains the patterns.

## 🧪 Testing

Locally modified filter to remove check for nimble.ni.dev and verified
that the section is now hidden.

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
  • Loading branch information
jattasNI authored Sep 6, 2023
1 parent bfab8b7 commit 4742c03
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Fix typo in hidden patterns docs",
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "none"
}
2 changes: 1 addition & 1 deletion packages/nimble-components/docs/patterns.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Meta } from '@storybook/addon-docs';

<Meta title="Patterns/Docs" />
<Meta title="patterns/Docs" />

# Patterns

Expand Down

0 comments on commit 4742c03

Please sign in to comment.