Skip to content

Commit

Permalink
Remove @ni/beachball-lock-update and update version of beachball (#109)
Browse files Browse the repository at this point in the history
# Justification

We were using the `@ni/beachball-lock-update` package to work around [a
bug](microsoft/beachball#525) with how
beachball modifies `package-lock.json` when publishing. That bug has
been addressed in more recent versions of beachball so we can stop using
the workaround.

This moves us towards fixing [this Nimble
issue](ni/nimble#601).

# Implementation

1. Remove `@ni/beachball-lock-update` from `package.json` and
`beachball.config.js`.
2. Install the latest version of `beachball`

# Testing

1. We've been running with this setup in Nimble for a few months and
it's worked well
2. I verified that basic beachball commands still work
3. I'll monitor the publishing pipeline as future changes go in. I
considered making a trivial edit to a pakckage to trigger a publish but
that seems pretty noisy now that our apps uptake new versions every
night.
  • Loading branch information
jattasNI authored Oct 4, 2022
1 parent e008e21 commit 5882a31
Show file tree
Hide file tree
Showing 3 changed files with 300 additions and 3,560 deletions.
9 changes: 0 additions & 9 deletions beachball.config.js

This file was deleted.

Loading

0 comments on commit 5882a31

Please sign in to comment.