Vendor in Sass-MQ

[pezholio]

Description

We're trying to use NHSUK Frontend on a project which has a non-standard location for node_modules, and as a result, we were getting the following error:

sass.CompileError: Error: File to import not found or unreadable: ./node_modules/sass-mq/mq.
        on line 17:1 of assets/_dev/node_modules/nhsuk-frontend/packages/core/tools/_sass-mq.scss
        from line 9:1 of assets/_dev/node_modules/nhsuk-frontend/packages/core/tools/_all.scss
        from line 6:1 of assets/_dev/scss/screen.scss
>> @import './node_modules/sass-mq/mq'; // [1] //

After a bit of Googling, I found that govuk-frontend had a similar problem and solved this by vendoring in SassMQ. I've attempted to replicate this approach in NHS Frontend too.

Thoughts welcome!

Checklist

• Tested against our testing policy (Resolution, Browser & Accessibility)
• Follows our coding standards and style guide
• CHANGELOG entry

[chrimesdev]

Hey @pezholio thanks for looking at this, seems like a sensible change to me. I'll get a second pair of eyes on this but looks good 👍

[mikemonteith]

Should we be using an includePath setting instead, and then have this in our scss:

@import 'sass-mq/mq';

https://sass-lang.com/documentation/at-rules/import#load-paths

[mikemonteith]

Should we be using an includePath setting instead, and then have this in our scss:

@import 'sass-mq/mq';

https://sass-lang.com/documentation/at-rules/import#load-paths

This would require all users of this library to also have an includePath in their build settings.

[pezholio]

Hey, any news on this? We'd really like to get back using the main version of NHSUK frontend, but this is blocking us

[chrimesdev]

Happy to stick with the approach in the PR as this is consistent with GOVUK frontend.

@pezholio please could you rebase this with master to be released in 4.1.0 and I can get this merged.

[pezholio]

@AdamChrimes All up to date and rebased! Lemme know if there's anything not quite right 👍

[chrimesdev]

Thanks @pezholio will get this released as part of v4.1.0 hopefully this week (26th at the very latest).