-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timeline component #92
Conversation
We are using colour to convey the past/present/future state. Do we need some markup for screen readers to do the same? |
Good point @mikemonteith - in all the example timelines I've seen across gov, they use a heading, but I haven't seen one with a heading and no content beneath. Maybe that example is a bad one (and a content problem?) and we need to change it? Also add guidance, eg: "it must have content beneath the heading". |
I'm not sure. We can include this in the accessibility testing we're planning. Note: It's not just using colour alone to convey past/present/future: bold text is used for present and different sized/shaped nodes are used for past and future. |
![]() Looking at the HTML output makes me wonder if we can refactor the CSS to make it a bit cleaner. Possibly use a 'background: node-blue.svg What do you think @edwardscull @mikemonteith ? |
Yes that would be cleaner for sure. It's an image that probably makes sense to be a background image. |
No description provided.