Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeline component #92

Merged
merged 4 commits into from
Jul 8, 2024
Merged

timeline component #92

merged 4 commits into from
Jul 8, 2024

Conversation

edwardscull
Copy link
Collaborator

No description provided.

@mikemonteith
Copy link
Collaborator

mikemonteith commented Jun 21, 2024

Not sure about the semantics of this.

"Request medication" is a heading but then it has no content below it.
Should be be looking at this being an ordered list instead?

image

Edit: I've just noticed that it is an ordered list!

@mikemonteith
Copy link
Collaborator

We are using colour to convey the past/present/future state. Do we need some markup for screen readers to do the same?

@davidhunter08
Copy link
Collaborator

Not sure about the semantics of this.

"Request medication" is a heading but then it has no content below it. Should be be looking at this being an ordered list instead?

image Edit: I've just noticed that it _is_ an ordered list!

Good point @mikemonteith - in all the example timelines I've seen across gov, they use a heading, but I haven't seen one with a heading and no content beneath.

Maybe that example is a bad one (and a content problem?) and we need to change it? Also add guidance, eg: "it must have content beneath the heading".

@davidhunter08
Copy link
Collaborator

davidhunter08 commented Jun 21, 2024

We are using colour to convey the past/present/future state. Do we need some markup for screen readers to do the same?

I'm not sure. We can include this in the accessibility testing we're planning.

Note: It's not just using colour alone to convey past/present/future: bold text is used for present and different sized/shaped nodes are used for past and future.

@edwardscull edwardscull linked an issue Jun 26, 2024 that may be closed by this pull request
@davidhunter08
Copy link
Collaborator

Screenshot 2024-07-02 at 15 33 37

Looking at the HTML output makes me wonder if we can refactor the CSS to make it a bit cleaner. Possibly use a 'background: node-blue.svgon theli:before`?

What do you think @edwardscull @mikemonteith ?

@edwardscull
Copy link
Collaborator Author

Screenshot 2024-07-02 at 15 33 37 Looking at the HTML output makes me wonder if we can refactor the CSS to make it a bit cleaner. Possibly use a 'background: node-blue.svg`on the`li:before`?

What do you think @edwardscull @mikemonteith ?

Yes that would be cleaner for sure. It's an image that probably makes sense to be a background image.

@davidhunter08 davidhunter08 merged commit 9f7f2ef into main Jul 8, 2024
4 checks passed
@davidhunter08 davidhunter08 deleted the timeline branch July 8, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeline (illustrative list)
3 participants