Retry text delivery server errors #2833
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
text-retry-failure
branch
from
170c9c9 to
b6167b3
Compare
tvararu
approved these changes
Jan 14, 2025
thomasleese
force-pushed
the
refactor-sms-delivery
branch
from
15a14cb to
a0bb987
Compare
thomasleese
force-pushed
the
text-retry-failure
branch
from
b6167b3 to
286f5cd
Compare
thomasleese
force-pushed
the
refactor-sms-delivery
branch
from
a0bb987 to
bb9449b
Compare
thomasleese
force-pushed
the
text-retry-failure
branch
from
286f5cd to
b5b19be
Compare
thomasleese
force-pushed
the
refactor-sms-delivery
branch
from
bb9449b to
20d2b8f
Compare
thomasleese
force-pushed
the
text-retry-failure
branch
from
b5b19be to
64507be
Compare
thomasleese
force-pushed
the
refactor-sms-delivery
branch
from
20d2b8f to
8da2f5b
Compare
If the text could not be delivered due to a server error, i.e. an issue with GOV.UK Notify, then we should keep trying to send these to avoid needing to manually re-send them via the Good Job dashboard.
thomasleese
force-pushed
the
text-retry-failure
branch
from
64507be to
4fdea52
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the text could not be delivered due to a server error, i.e. an issue with GOV.UK Notify, then we should keep trying to send these to avoid needing to manually re-send them via the Good Job dashboard.