Change how check-file-format.sh checks changed files #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefaniuk
requested changes
Sep 14, 2023
|
Think that's done now. We've got the modes as described here, and I've added a |
Prior to this patch, the `git diff` command used to identify which files to check for editorconfig compliance caught too many files, and did the expensive part of the check inside the per-file loop. By lucky chance, the editorconfig-checker container image has a `git` binary installed, so we can move the entire loop inside a single container invocation. Fixes #129.
stefaniuk
force-pushed
the
editorconfig-loop
branch
from
4123bf8 to
18af9e0
Compare
stefaniuk
requested changes
Sep 25, 2023
|
Do we know how the 18af9e0 force-push happened? |
Yes, I brought this branch in sync with |
stefaniuk
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this patch, the
git diffcommand used to identify which files to check for editorconfig compliance caught too many files, and did the expensive part of the check inside the per-file loop.By lucky chance, the editorconfig-checker container image has a
gitbinary installed, so we can move the entire loop inside a single container invocation.Fixes #129.
Context
It makes the editorconfig check, which is called in a pre-commit hook, fast.
Type of changes