fix(hybrid): allow sending redirect_uri param to avoid redirect URI mismatch errors #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #115
Summary
When using
omniauth-apple
with a API only Rails application it's common for the initial request to be made from the client side application instead of from Rails.The client side application then receives a authorization code which it POST to
/auth/apple/callback
and the code is verified from the API before finally signing the user in.When doing so the
redirect_uri
used in the callback process needs to be the same as theredirect_uri
used in the request process so we need to be able to share thatredirect_uri
from the client side app to the API.This is also the case with other
omniauth-<provider>
gem.This PR allows sending a
redirect_uri
param to the/auth/apple/callback
endpoint from a client side application and ensures that param will be used when present to avoid redirect uri mismatch errors.Until this PR is merged this issue can be monkey patched by initializing a custom class that will override this gem