Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent None paths from breaking code in get_url. #28

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

ndesamuelmbah
Copy link

Added code to prevent None string values in Path from breaking code when getting urls of storage paths.
Also ensured that we are removing all trailing "/" characters from paths when necessary by converting path = path[1:] to path = path.lstrip('/')

Added code to prevent None string values in Path from breaking code when getting urls of storage paths.
Also ensured that we are removing all trailing "/" characters from paths when necessary by converting path = path[1:]  to path = path.lstrip('/')
@ndesamuelmbah
Copy link
Author

Hello Folks,
I ran into some problems with None string values being set to the value of path in storage class and the trying to apply startswith on the path value. I thought it would be better to have it fixed in the package than to have me fix it only for myself.

Copy link

@arham-sayyed arham-sayyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awsome fix!

Was stuck on this problem for literal 2 days! thankyou very much for this fix.
Your PR must be merged soon!

Thanks a lot Again!

@nhorvath nhorvath merged commit 7fcfda1 into nhorvath:master Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants