Skip to content

Commit

Permalink
Fix shell port bug in computation of QMK_FIRMWARE_DIR (qmk#13950)
Browse files Browse the repository at this point in the history
Previous code would fail if cd echoes the tathet directory to stdout,
which is pretty common.  Redirecting its output to /dev/null
solves the problem.
  • Loading branch information
eric-s-raymond authored and nhongooi committed Dec 5, 2021
1 parent 5102071 commit 5025b7c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion util/qmk_install.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

QMK_FIRMWARE_DIR=$(cd -P -- "$(dirname -- "$0")/.." && pwd -P)
QMK_FIRMWARE_DIR=$(cd -P -- "$(dirname -- "$0")/.." >/dev/null && pwd -P)
QMK_FIRMWARE_UTIL_DIR=$QMK_FIRMWARE_DIR/util
if [ "$1" = "-y" ]; then
SKIP_PROMPT='-y'
Expand Down

0 comments on commit 5025b7c

Please sign in to comment.