-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check/uncheck event emitted when multi check/uncheck via shift click #1965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이건 테스트가 좀 어렵나요? 루프가 들어가서 조금 많은 데이터 테스트가 한 번 들어가면 좋겠다 싶어요.
테스트 추가 했는데, Cypress 4.9.0에서는 Shift-Click을 테스트 할 수가 없네요... 다른 방법이 있을까 이리 저리 찾아봤는데 현재로써는 해당 버전에 문서 차제에 접근이 불가능 한 것으로 보입니다. 그래서 API 호출을 이용한 동작에만 테스트를 추가 했습니다. |
5.0.0에서 추가됐네요. cypress-io/cypress#486 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 완료합니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
Please check if the PR fulfills these requirements
fix #xxx[,#xxx]
, where "xxx" is the issue number)Description
Fixed an issue where multiple checks/unchecks using shift-click did not raise the check/unchecked event.
When an event is fired due to a single checkbox click, the event handler is passed the same arguments as before, but when an event is fired due to a multiple checkbox check, the event handler is passed
rowKeys
as an argument, which is an array containing all rowKeys instead ofrowKey
.Thank you for your contribution to TOAST UI product. 🎉 😘 ✨