Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NHibernate to 5.3.3 #475

Merged
merged 3 commits into from
Oct 14, 2020
Merged

Update NHibernate to 5.3.3 #475

merged 3 commits into from
Oct 14, 2020

Conversation

hazzik
Copy link
Member

@hazzik hazzik commented Oct 9, 2020

Fixes #429

@hazzik hazzik added the feature label Oct 9, 2020
gliljas
gliljas approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@gliljas gliljas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gliljas
Copy link
Member

gliljas commented Oct 9, 2020

Or were the failing tests the mystery?

@Tradioyes
Copy link

Some of the tests (like StringLambdaOutputListenerTests) fail because FakeItEasy v4.3.0 has trouble with .netCore 2.1. They are solved by upgrading FakeItEasy.

The trickier problem is tests like When_a_reference_list_is_registered_on_the_persistence_specification. Those fail because the NHibernate implementation of GetCurrentTransaction isn't mocked, and is not mockable because it's an extension method. It's called in PersistenceSpecification<T>. GetCurrentTransaction wasn't used previously, it replaces session.Transaction which has been made obsolete.

We have to find a workaround, I haven't found it yet.

@gliljas
Copy link
Member

gliljas commented Oct 10, 2020

This PR #476 solves it. It's not beautiful, but I believe it's the best way for now, until the GetCurrentTransaction method becomes part of ISession, instead of being an extension method.

@hazzik
Copy link
Member Author

hazzik commented Oct 10, 2020

The plan was to remove GetCurrentTransaction

@hazzik hazzik merged commit f3ced06 into master Oct 14, 2020
@hazzik hazzik deleted the nhibernate-5.3 branch October 14, 2020 08:20
@hazzik hazzik added this to the 3.1.0 milestone Oct 14, 2020
@hazzik hazzik added feature and removed feature labels Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gliljas gliljas gliljas approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

Update NHibernate to 5.3.3
3 participants
@hazzik @gliljas @Tradioyes