NHibernate 5.2.7 and SQL Anywhere 17 support #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQL Anywhere 17.
|
Anyone still minding this project? |
|
It would be great if higher NHibernate releases were supported. |
|
I'm not an official reviewer of this project, but I can see a few problems with this PR. Firstly, you're mixing 2 different changes in 1 commit. Ideally they should be separate PRs, but at the least separate commits. Secondly, it's pretty clear that the NHibernate package version is coming from a different configuration source, specifically in |
igitur
reviewed
Aug 26, 2020
igitur
reviewed
Aug 26, 2020
src/Examples.FirstAutomappedProject/Examples.FirstAutomappedProject.csproj
Outdated
Show resolved
Hide resolved
This was referenced Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NHibernate 5.2.* has support for SQL Anywher 17. Therefore I upgraded to 5.2.7 and added support for SQL Anywhere. All tests are passing.
Not sure how you manage the $(NHibernatePackageVersion) variable. I manually changed it to 5.2.7 using Nuget.
Changed global.json version to 2.1.700, couldn't find the correct version on https://dotnet.microsoft.com/download/visual-studio-sdks