[mypy] Stop ignoring msgraph-sdk-python-core #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually the issue causing the revert might not be related to not being uploaded to PyPI but instead version pinning: parsedmarc-fork/pyproject.toml Line 61 in 9442a47 |
|
Our version pinning because of the breaking changes means that we can't access the type stubs. We're going to have to do fix the breaking changes from moving to I'm going to drop this PR but continue to work on the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed in microsoftgraph/msgraph-sdk-python-core#674
This commit re-applies the commit reverted in 9442a47