fix(search-result) scrolling visibility #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes scrolling visibility on mat-card-content
|
Hi @geromegrignon thanks for your PR. Could you, however, remove the package-lock.json from the changes? |
removes package-lock.json file fixes #26
|
Hi, i removed the file. |
|
Oh! you deleted the file! Sorry, that was not what I meant. I was talking about not committing the package-lock.json file with this PR. You could just git revert your changes for instance. Sorry for not being specific about that. |
|
My fault too : starting contributing, i need to be more careful. |
|
No big deal 😇 You can git add the package-lock.json file back and push it. I'll take care of that. |
adds package-lock.json fixes #26
manekinekko
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes scrolling visibility on mat-card-content as overflow-x was visible by default.
It's only displayed when needed now.