Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Consistently return Ints for time to satisfy typed systems #32

Merged
merged 1 commit into from
Jan 22, 2021
Merged

fix: Consistently return Ints for time to satisfy typed systems #32

merged 1 commit into from
Jan 22, 2021

Conversation

moonmeister
Copy link
Contributor

Fix the floating point issues using Math.round so that Ints are consistently returned for use in typed systems

@moonmeister
fix: use Math.round to resolve floating point rounding issues so that…
ef4abd9 
… Ints are consistently returned for use in typed systems
@ngryman ngryman merged commit 8042b80 into ngryman:master Jan 22, 2021
@ngryman
Copy link
Owner

ngryman commented Jan 22, 2021

Makes sense, thanks!

@moonmeister
Copy link
Contributor Author

When can I expect to see this in a release? thanks.

@moonmeister moonmeister deleted the floating-point-issues branch January 26, 2021 14:29
@ngryman
Copy link
Owner

ngryman commented Jan 29, 2021

@moonmeister Released as 1.3.0!

@moonmeister
Copy link
Contributor Author

Thanks!

@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moonmeister @ngryman