Skip to content
This repository has been archived by the owner on Jan 10, 2018. It is now read-only.

sourcemap warning #180

Closed
ritz078 opened this issue Aug 2, 2016 · 14 comments
Closed

sourcemap warning #180

ritz078 opened this issue Aug 2, 2016 · 14 comments
Labels

Comments

@ritz078
Copy link

ritz078 commented Aug 2, 2016

Angular cli : current master having webpack.

WARNING in ./~/@ngrx/core/compose.js
Cannot find source file '../../lib/compose.ts': Error: Can't resolve '../../lib/compose.ts' in '/Users/ritz078/projects/ng-housing/node_modules/@ngrx/core'
 @ ./src/main.ts 5:0-45
 @ multi main

WARNING in ./~/@ngrx/core/SyncSubject.js
Cannot find source file '../../lib/SyncSubject.ts': Error: Can't resolve '../../lib/SyncSubject.ts' in '/Users/ritz078/projects/ng-housing/node_modules/@ngrx/core'
 @ ./~/@ngrx/store/dispatcher.js 7:20-53
 @ ./~/@ngrx/store/index.js
 @ ./src/main.ts
 @ multi main

WARNING in ./~/@ngrx/core/operator/select.js
Cannot find source file '../../../lib/operator/select.ts': Error: Can't resolve '../../../lib/operator/select.ts' in '/Users/ritz078/projects/ng-housing/node_modules/@ngrx/core/operator'
 @ ./~/@ngrx/store/store.js 8:15-52
 @ ./~/@ngrx/store/index.js
 @ ./src/main.ts
 @ multi main
@mb-jenks
Copy link

mb-jenks commented Aug 6, 2016

+1

@MikeRyanDev
Copy link
Member

This will be fixed in the next releases of ngrx/store and ngrx/core

@psyCodelist
Copy link

Still see the issue in 2.1.2.

@mmrath
Copy link

mmrath commented Aug 16, 2016

It would be nice to get this fixed. Lot of warnings

@MikeRyanDev
Copy link
Member

@ngrx/core v1.0.2 published without sourcemaps to remove these errors.

@MikeRyanDev
Copy link
Member

Reopening. Didn't realize sourcemaps were broken in the latest release of Store. 🔥

@MikeRyanDev MikeRyanDev reopened this Aug 16, 2016
@robwormald
Copy link
Contributor

ahh crap. meant to handle this in the last release. @MikeRyan52 are you inlining the sourcemaps or?

@MikeRyanDev
Copy link
Member

@robwormald There's some magic incantation using sourceMap, sourceRoot, and moduleRoot to get the sourcemaps working correctly that I haven't had the time to fully investigate yet. As a quick fix I've temporarily skipped generating them in effects and core.

@Meligy
Copy link

Meligy commented Aug 28, 2016

@robwormald @MikeRyan52 can you guys please see if this PR #200 is a good solution for this?

Thanks heaps for all the awesomeness :)

@ggranum
Copy link

ggranum commented Sep 5, 2016

Angular-cli 1.0.0-beta.11-webpack.3 silences these warnings:
https://github.com/angular/angular-cli/blob/master/CHANGELOG.md

  • build: silence sourcemap warnings for vendors (#1673) (67098e0)

@Meligy
Copy link

Meligy commented Sep 5, 2016

Silencing the warning is the the CLI is -of course- CLI specific. It doesn't affect people using AngularClass/angular2-webpack-starter for example.

@mmrath
Copy link

mmrath commented Sep 17, 2016

@robwormald, @ MikeRyan52 is there a fix or workaround for this issue. I use many libraries but only ngrx has this issue

@MikeRyanDev
Copy link
Member

@mmrath Sourcemaps should have been fixed in v2.2.0.

@mmrath
Copy link

mmrath commented Sep 17, 2016

@MikeRyan52 Thank you. I just upgraded and the warnings went away.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

8 participants