feat(ErrorHandler): use the angular ErrorHandler for reporting errors #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ErrorHandler reports to the console by default, so it wouldn't be a breaking change. |
|
It is a breaking change if #635 gets released in v4. Shall I remove the breaking change from the commit message though? |
|
@jbedard The breaking change should remain, but the format should be altered so it shows in the changelog correctly.. |
|
@jbedard this one is ready to land once the commit message is updated. |
jbedard
force-pushed
the
626-drop-console
branch
from
9eb1402 to
66973d1
Compare
Fixes ngrx#626 BREAKING CHANGE: the ErrorReporter has been replaced with ErrorHandler from angular/core. BEFORE: Errors were reported to the ngrx/effects ErrorReporter. The ErrorReporter would log to the console by default. AFTER: Errors are now reported to the @angular/core ErrorHandler.
jbedard
force-pushed
the
626-drop-console
branch
from
66973d1 to
23b98b8
Compare
|
I've updated the commit message, and rebased. Let me know if the commit message is ok... |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #626
This is a v5 alternative to #635. Can potentially try to keep
InvalidActionErrorandEffectErrorbut I'm not sure if that is a standard thing to do withErrorHandler?BREAKING CHANGE:
Errors are now reported to the @angular/core ErrorHandler.
Errors are no longer reported to the console.