Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RouterStore): Fix cancelled navigation with async guard (fixes #354) #355

Merged
merged 1 commit into from
Sep 7, 2017
Merged

fix(RouterStore): Fix cancelled navigation with async guard (fixes #354) #355

merged 1 commit into from
Sep 7, 2017

Conversation

kondi
Copy link
Contributor

@kondi kondi commented Sep 6, 2017

Fix for #354, see more details there.
Contains unit test which fails without the fix.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 91.243% when pulling 13feb6c on kondi:cancel-fix into 28e1983 on ngrx:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 91.243% when pulling f0e9cea on kondi:cancel-fix into 28e1983 on ngrx:master.

@brandonroberts brandonroberts merged commit 920c0ba into ngrx:master Sep 7, 2017
@brandonroberts
Copy link
Member

Thanks!

@brandonroberts brandonroberts mentioned this pull request Sep 7, 2017
Closed
@GulajavaMinistudio GulajavaMinistudio mentioned this pull request Sep 7, 2017
Merged
@brandonroberts brandonroberts mentioned this pull request Oct 5, 2017
Closed
@brandonroberts brandonroberts mentioned this pull request Oct 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kondi @coveralls @brandonroberts