Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redux DevTools name option. #463

Closed
krismeister opened this issue Oct 9, 2017 · 5 comments
Closed

Add Redux DevTools name option. #463

krismeister opened this issue Oct 9, 2017 · 5 comments

Comments

@krismeister
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ X ] Feature request
[ ] Documentation issue or request

What is the current behavior?

There is no support for the __REDUX_DEVTOOLS_EXTENSION_COMPOSE__ name option, so you can not see a friendly name in the Redux DevTools AutoSelect instances dropdown.

Expected behavior:

It would be convenient to pass a name variable with the StoreDevtoolsOptions when calling StoreDevtoolsModule.instrument

@rupeshtiwari
Copy link
Contributor

Hi @brandonroberts I would like to work on this an create PR.

@brandonroberts
Copy link
Member

Hey @roopkt, we'll accept a PR for this

@rupeshtiwari
Copy link
Contributor

rupeshtiwari commented Oct 20, 2017

Hi @brandonroberts I checked in the fix in my forked branch. Not sure why its not showing me to the option to create PR.

@rupeshtiwari
Copy link
Contributor

Hi @brandonroberts I am not able to rebase or fetch from upstream it says access denied.

git fetch upstream
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists

@rupeshtiwari
Copy link
Contributor

@brandonroberts I finished fixing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants