Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoreDevtoolsModule: Instrument only with extension for production mode? #374

Closed
maxime1992 opened this issue Sep 11, 2017 · 8 comments
Closed

Comments

@maxime1992
Copy link
Contributor

I'm submitting a...


[ x ] Documentation issue or request

What is the current behavior?

In order to use the devtool, I have the following code:

!environment.production
      ? StoreDevtoolsModule.instrument({ maxAge: 50 })
      : [],

The thing is, I used to do StoreDevtoolsModule.instrumentOnlyWithExtension()

Expected behavior:

I'd like to be able to use the redux devtools even in production IF the extension is present and launched.

How can I do that with ngrx V4 and the latest devtools?

@AhsanAyaz
Copy link

@maxime1992 I went through the forked code.
I don't see instrumentOnlyWithExtension anymore in the code.
@brandonroberts is there a possibility to bring that back?

@rupeshtiwari
Copy link
Contributor

@brandonroberts should I work on this?

@maxime1992
Copy link
Contributor Author

@roopkt have you tried something? :)

It's been two months and a half without any "official" answer and I think that if you know how to start on this it might be 👌

@rupeshtiwari
Copy link
Contributor

Hi @maxime1992 ,
I started working on this and then stopped.
Because, I am waiting for @brandonroberts to approve for starting a pull request.

@nickroberts
Copy link

Check the migration guide on how to handle in production.

@brandonroberts
Copy link
Member

@roopkt @maxime1992 we removed this option previously because of injector issues with Angular. It also streamlined the code path for instrumenting. I'd be open to this being added back if its reliable.

@Lobaton2020
Copy link

I just used StoreDevtoolsModule.instrument(...) instead StoreDevtoolsModule.instrumentOnlyWithExtension(...).
And that have worked for me

@maxime1992
Copy link
Contributor Author

@Lobaton2020 the recommended way is now documented here: https://ngrx.io/guide/store-devtools/recipes/exclude

I've been using this for a long time and it works perfectly too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants