Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NGINX Prometheus Exporter with systemd-activated socket #800

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

huangsijun17
Copy link
Contributor

@huangsijun17 huangsijun17 commented Aug 9, 2024

Proposed changes

Add "Steps to add users"

Closes #799

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

Just a documentation update, validation code and test cases?

Add "Steps to add users"

Signed-off-by: huangsijun17 <[email protected]>
@huangsijun17 huangsijun17 requested a review from a team as a code owner August 9, 2024 03:00
Copy link

nginx-bot bot commented Aug 9, 2024

Hi @huangsijun17! Welcome to the project! 🎉

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

@nginx-bot nginx-bot bot added the community Issues or PRs opened by an external contributor label Aug 9, 2024
Copy link

github-actions bot commented Aug 9, 2024

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Aug 9, 2024
@huangsijun17
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @huangsijun17 !

@lucacome lucacome requested a review from a team August 12, 2024 17:00
@lucacome lucacome merged commit 661bad6 into nginxinc:main Aug 13, 2024
16 checks passed
@huangsijun17 huangsijun17 deleted the patch-1 branch August 13, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues or PRs opened by an external contributor documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the systemd deployment documentation, the step of creating a new user is missing.
3 participants