Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set upstream zone size to 512k #609

Merged
merged 3 commits into from
May 3, 2023
Merged

Set upstream zone size to 512k #609

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
876cde0
Set upstream zone size to 512k
kate-osborn May 3, 2023
c8ac5a1
Add comment about why 512k
kate-osborn May 3, 2023
0ebad67
Appease linter
kate-osborn May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal/nginx/config/upstreams_template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
package config

// FIXME(kate-osborn): Add upstream zone size for each upstream.
// This should be dynamically calculated based on the number of upstreams.
// FIXME(kate-osborn): Dynamically calculate upstream zone size based on the number of upstreams.
kate-osborn marked this conversation as resolved.
Show resolved Hide resolved
// 512k will support up to 648 upstream servers.
var upstreamsTemplateText = `
{{ range $u := . }}
upstream {{ $u.Name }} {
random two least_conn;
zone {{ $u.Name }} 512k;
{{ range $server := $u.Servers }}
server {{ $server.Address }};
{{- end }}
Expand Down