Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit empty deployment context fields (#2903) #2910

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

sjberman
Copy link
Contributor

Problem: If an optional deployment context field wasn't set, an empty value would still be sent and cause the reporting server to return a 400.

Solution: Use pointers on the optional fields to omit them from the context if they're empty.

Problem: If an optional deployment context field wasn't set, an empty value would still be sent and cause the reporting server to return a 400.

Solution: Use pointers on the optional fields to omit them from the context if they're empty.
@sjberman sjberman requested a review from a team as a code owner December 13, 2024 21:19
@github-actions github-actions bot added the bug Something isn't working label Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.71%. Comparing base (e153640) to head (616f397).
Report is 1 commits behind head on release-1.5.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.5    #2910   +/-   ##
============================================
  Coverage        89.71%   89.71%           
============================================
  Files              109      109           
  Lines            11091    11091           
  Branches            50       50           
============================================
  Hits              9950     9950           
  Misses            1082     1082           
  Partials            59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman sjberman enabled auto-merge (squash) December 13, 2024 21:24
@sjberman sjberman merged commit 9c2deea into release-1.5 Dec 13, 2024
22 of 24 checks passed
@sjberman sjberman deleted the fix/cherry-pick-dep-ctx-fix branch December 13, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants