Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix netlify url preview #1344

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

nginx-jack
Copy link
Contributor

@nginx-jack nginx-jack commented Dec 6, 2023

Proposed changes

Problem: Netlify preview url is not rendering properly

Solution: Fix url to be postfixed with /nginx-gateway-fabric/

Testing: PR creation should generate a preview url.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-jack nginx-jack requested a review from a team as a code owner December 6, 2023 16:07
Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for nginx-gateway-fabric ready!

Name Link
🔨 Latest commit 5a4a390
🔍 Latest deploy log https://app.netlify.com/sites/nginx-gateway-fabric/deploys/65709c2aea0bb9000806cb97
😎 Deploy Preview https://deploy-preview-1344--nginx-gateway-fabric.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I flagged this issue earlier when clicking the preview for my open PR.

@kate-osborn kate-osborn merged commit df69c44 into nginxinc:main Dec 6, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants