-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PartiallyInvalid HTTPRoute Condition #1160
Add PartiallyInvalid HTTPRoute Condition #1160
Conversation
Since we are using our own version of PartiallyInvalid (copied from Gateway sig), should I open up a ticket which is for switching to their definition when they release it in 1.0? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff!
please see a few change requests.
naming suggestions aim to bring consistency with the existing code. for cases, when there is a valid rule(s) but some are invalid, we can use "dropped" in the name of variables and cases in tests.
9bec288
to
1cf60ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Proposed changes
Replace previously used TODO Conditions with PartiallyInvalid HTTPRoute Condition.
Problem: There was no HTTPRoute Condition that conveyed when a Route was PartiallyInvalid.
Solution: Added the PartiallyInvalid HTTPRoute Condition.
Testing: Manually deployed HTTPRoute with invalid and valid rules and checked to see if the HTTPRoute correctly displayed the new condition. Also checked to see if the matches are valid, with an invalid filter, that the HTTPRoute correctly displayed the new condition. Added additional Unit Tests.
Please focus on (optional): Did I update all the documentation? Are the tests that I added all necessary and done correctly?
Closes #485
Checklist
Before creating a PR, run through this checklist and mark each as complete.