Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGF fails to deploy on Openshift #1674

Closed
bjee19 opened this issue Mar 12, 2024 · 4 comments · Fixed by #1976
Closed

NGF fails to deploy on Openshift #1674

bjee19 opened this issue Mar 12, 2024 · 4 comments · Fixed by #1976
Assignees
Labels
enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week
Milestone

Comments

@bjee19
Copy link
Contributor

bjee19 commented Mar 12, 2024

Describe the bug
NGF fails to deploy on Openshift when using helm chart

output:

[cloud-user@ocp-provisioner nginx-gateway-fabric]$ helm install ngf oci://ghcr.io/nginxinc/charts/nginx-gateway-fabric --create-namespace -n nginx-gateway
Pulled: ghcr.io/nginxinc/charts/nginx-gateway-fabric:1.1.0
Digest: sha256:2a3aa5e2b61334a135b909f389b190ed9514b2d77c529068eb3bef4e08d0f7ec
W0312 16:49:51.427508   14348 warnings.go:70] would violate PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "nginx" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "nginx-gateway" must not include "KILL" in securityContext.capabilities.add), seccompProfile (pod or containers "nginx-gateway", "nginx" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")

Deployment is created with this condition:

status:
  conditions:
  - lastTransitionTime: "2024-03-12T20:49:51Z"
    lastUpdateTime: "2024-03-12T20:49:51Z"
    message: Created new replica set "ngf-nginx-gateway-fabric-777dc84497"
    reason: NewReplicaSetCreated
    status: "True"
    type: Progressing
  - lastTransitionTime: "2024-03-12T20:49:51Z"
    lastUpdateTime: "2024-03-12T20:49:51Z"
    message: Deployment does not have minimum availability.
    reason: MinimumReplicasUnavailable
    status: "False"
    type: Available
  - lastTransitionTime: "2024-03-12T20:49:51Z"
    lastUpdateTime: "2024-03-12T20:49:51Z"
    message: 'pods "ngf-nginx-gateway-fabric-777dc84497-" is forbidden: unable to
      validate against any security context constraint: [provider "anyuid": Forbidden:
      not usable by user or serviceaccount, provider restricted-v2: .spec.securityContext.fsGroup:
      Invalid value: []int64{1001}: 1001 is not an allowed group, spec.containers[0].securityContext.runAsUser:
      Invalid value: 102: must be in the ranges: [1000700000, 1000709999], spec.containers[0].securityContext.capabilities.add:
      Invalid value: "KILL": capability may not be added, spec.containers[1].securityContext.runAsUser:
      Invalid value: 101: must be in the ranges: [1000700000, 1000709999], provider
      "restricted": Forbidden: not usable by user or serviceaccount, provider "nonroot-v2":
      Forbidden: not usable by user or serviceaccount, provider "nonroot": Forbidden:
      not usable by user or serviceaccount, provider "hostmount-anyuid": Forbidden:
      not usable by user or serviceaccount, provider "machine-api-termination-handler":
      Forbidden: not usable by user or serviceaccount, provider "hostnetwork-v2":
      Forbidden: not usable by user or serviceaccount, provider "hostnetwork": Forbidden:
      not usable by user or serviceaccount, provider "hostaccess": Forbidden: not
      usable by user or serviceaccount, provider "node-exporter": Forbidden: not usable
      by user or serviceaccount, provider "privileged": Forbidden: not usable by user
      or serviceaccount]'
    reason: FailedCreate
    status: "True"
    type: ReplicaFailure
  observedGeneration: 1
  unavailableReplicas: 1


To Reproduce

  1. Create Openshift cluster
  2. Install gateway api resources
  3. Run helm install ngf oci://ghcr.io/nginxinc/charts/nginx-gateway-fabric --create-namespace -n nginx-gateway

Expected behavior
NGF deploys correctly.

Your environment

  • Version of the NGINX Gateway Fabric - 1.1.0
  • Version of Kubernetes - 1.25.10
  • Kubernetes platform (e.g. Mini-kube or GCP) - Openshift v4.12.20
@sjberman
Copy link
Contributor

Ah of course, OpenShift. We'll need to create a SecurityContextConstraint that has the proper permissions to deploy NGF.

@mpstefan mpstefan added this to the v1.3.0 milestone Mar 21, 2024
@sy-be
Copy link

sy-be commented Apr 19, 2024

Would be great to have this documented and why we need these extra capabilities, especially the KILL.

@mpstefan mpstefan added enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. labels Apr 22, 2024
@mpstefan
Copy link
Collaborator

We may be able to look at NIC's SCC available here

@mpstefan mpstefan added the size/medium Estimated to be completed within a week label Apr 22, 2024
@sjberman
Copy link
Contributor

sjberman commented May 2, 2024

We'll also probably require a field in our helm chart to say whether we are on kubernetes or openshift to determine whether or not to create the SCC when installing.

An update to our installation docs will be required to explain this, and we should also add a reference doc to describe the permissions we use and why we use them.

@bjee19 bjee19 self-assigned this May 7, 2024
@bjee19 bjee19 moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric May 7, 2024
@bjee19 bjee19 moved this from 🏗 In Progress to 👀 In Review in NGINX Gateway Fabric May 17, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants