-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow NGF to run on Openshift #1976
Merged
bjee19
merged 34 commits into
nginxinc:main
from
bjee19:fix/fails-to-deploy-on-openshift
May 28, 2024
Merged
Allow NGF to run on Openshift #1976
bjee19
merged 34 commits into
nginxinc:main
from
bjee19:fix/fails-to-deploy-on-openshift
May 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
Something isn't working
documentation
Improvements or additions to documentation
helm-chart
Relates to helm chart
labels
May 15, 2024
bjee19
commented
May 15, 2024
bjee19
commented
May 15, 2024
bjee19
commented
May 15, 2024
Documentation on additional steps when installing NGF on an Openshift environment is still in progress, would like some feedback on the current SCC file and the references documentation. |
sjberman
reviewed
May 15, 2024
kate-osborn
requested changes
May 15, 2024
sjberman
reviewed
May 16, 2024
Decided to split out the openshift-permissions / NGF permissions into a separate issue found here #1985 , will be resolving/closing all reviews dealing with that document. |
ciarams87
reviewed
May 17, 2024
sjberman
reviewed
May 17, 2024
sjberman
reviewed
May 17, 2024
bjee19
force-pushed
the
fix/fails-to-deploy-on-openshift
branch
from
May 20, 2024 22:03
fa18b7b
to
1dd9543
Compare
bjee19
commented
May 22, 2024
site/content/installation/installing-ngf/manifests-openshift.md
Outdated
Show resolved
Hide resolved
bjee19
commented
May 22, 2024
site/content/installation/installing-ngf/manifests-openshift.md
Outdated
Show resolved
Hide resolved
pleshakov
reviewed
May 22, 2024
lucacome
reviewed
May 22, 2024
bjee19
commented
May 23, 2024
bjee19
force-pushed
the
fix/fails-to-deploy-on-openshift
branch
from
May 28, 2024 17:33
4f28bbf
to
2573e90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
helm-chart
Relates to helm chart
release-notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SecurityContextConstraints for NGF, documentation on additional steps when installing NGF on an Openshift environment.
Problem: NGF fails to deploy on Openshift.
Solution: Add SecurityContextConstraints for NGF, giving NGF to correct permissions to deploy on Openshift.
Testing: Manual deployment of NGF with NGINX and NGINX+. Also set up the cafe example and ensured traffic flowed.
After manual deployment of NGF, here is the cafe example directing traffic correctly:
After manual deployment of NGF with NGINX+, here is the cafe example directing traffic correctly:
Closes #1674
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.