Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] Re-add FIPs images to tests, image patching & release #6972

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[cherry-pick] Re-add FIPs images to tests, image patching & release #6972

merged 1 commit into from
Dec 12, 2024

Conversation

nginx-bot
Copy link
Contributor

Proposed changes

Re-add FIPS related images to tests, image patching & release process. closes #5914

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@haywoodsh @pdabelf5
@vepatel @web-flow
Re-add FIPs images to tests, image patching & release (#6948)
53ddd1f 
* add fips image to pipeline
Signed-off-by: Haywood Shannon <[email protected]>

Signed-off-by: Haywood Shannon <[email protected]>

* re-add fips images to patching and release

* add fips images to tech specs

* remove FIPS note from release notes

* switch tests for fips

---------

Signed-off-by: Haywood Shannon <[email protected]>
Co-authored-by: Paul Abel <[email protected]>
Co-authored-by: Paul Abel <[email protected]>
Co-authored-by: Venktesh Shivam Patel <[email protected]>
@nginx-bot nginx-bot added the chore Pull requests for routine tasks label Dec 12, 2024
@nginx-bot nginx-bot requested a review from a team as a code owner December 12, 2024 12:25
@nginx-bot nginx-bot added documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch labels Dec 12, 2024
@nginx-bot nginx-bot requested a review from a team as a code owner December 12, 2024 12:25
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6972/

@pdabelf5 pdabelf5 removed the needs cherry pick Cherry pick this PR into a release branch label Dec 12, 2024
@pdabelf5 pdabelf5 merged commit b1a4903 into release-4.0 Dec 12, 2024
23 checks passed
@pdabelf5 pdabelf5 deleted the cherry-pick-release-4.0-606b33b3fe00c1a7956c1a6e5e738eb106e3f341 branch December 12, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@vepatel vepatel vepatel approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nginx-bot @vepatel @jjngx @pdabelf5 @haywoodsh