Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go client and prometheus exporter #6916

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Dec 4, 2024

Proposed changes

Update go client from v1.3 to v2.1 and prometheus exporter from v1.3 to v1.4 for upcoming r33 changes

added logger from slog to pre-exisiting uses too as we now have slog imported.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner December 4, 2024 14:20
@github-actions github-actions bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.96%. Comparing base (7c1e6c1) to head (73c503f).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/nginx/manager.go 0.00% 5 Missing ⚠️
cmd/nginx-ingress/main.go 0.00% 1 Missing ⚠️
internal/metrics/listener.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6916      +/-   ##
==========================================
- Coverage   53.15%   52.96%   -0.19%     
==========================================
  Files          88       88              
  Lines       20396    20591     +195     
==========================================
+ Hits        10842    10907      +65     
- Misses       9111     9237     +126     
- Partials      443      447       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 mentioned this pull request Dec 4, 2024
6 tasks
@AlexFenlon AlexFenlon enabled auto-merge (squash) December 4, 2024 15:50
@AlexFenlon AlexFenlon merged commit 39b285d into main Dec 4, 2024
80 checks passed
@AlexFenlon AlexFenlon deleted the chore/upgrade-go-client branch December 4, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants