Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events when special secrets update #6878

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Nov 27, 2024

Proposed changes

add events to each special secret during start up

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner November 27, 2024 16:01
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 53.16%. Comparing base (8b8fc52) to head (33a83d3).
Report is 53 commits behind head on main.

Files with missing lines Patch % Lines
cmd/nginx-ingress/main.go 0.00% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6878      +/-   ##
==========================================
- Coverage   53.24%   53.16%   -0.09%     
==========================================
  Files          88       88              
  Lines       20363    20394      +31     
==========================================
  Hits        10842    10842              
- Misses       9078     9109      +31     
  Partials      443      443              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 force-pushed the add-events-to-special-secrets branch from 1c2b044 to ea66430 Compare November 28, 2024 12:19
@AlexFenlon AlexFenlon merged commit 74a8187 into main Nov 28, 2024
81 checks passed
@AlexFenlon AlexFenlon deleted the add-events-to-special-secrets branch November 28, 2024 14:45
@pdabelf5 pdabelf5 changed the title add events to special secrets Add events to special secrets Dec 16, 2024
@pdabelf5 pdabelf5 changed the title Add events to special secrets Add events when special secrets update Dec 16, 2024
@pdabelf5 pdabelf5 added enhancement Pull requests for new features/feature enhancements and removed go Pull requests that update Go code labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants