Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update oidc.conf #6837

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Update oidc.conf #6837

merged 3 commits into from
Nov 21, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Nov 21, 2024 •
edited
Loading

Proposed changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner November 21, 2024 11:29
@github-actions github-actions bot added the bug An issue reporting a potential bug label Nov 21, 2024
jjngx
jjngx approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vepatel vepatel linked an issue Nov 21, 2024 that may be closed by this pull request
[Bug]: v3.7.1 break the OIDC integration with Okta #6812
Closed
@vepatel vepatel enabled auto-merge (squash) November 21, 2024 13:08
@vepatel vepatel merged commit 1ce438c into main Nov 21, 2024
82 checks passed
@vepatel vepatel deleted the fix/oidc branch November 21, 2024 13:09
vepatel added a commit that referenced this pull request Nov 21, 2024
@vepatel
update oidc.conf and template (#6837)
b501fde
@pdabelf5 pdabelf5 changed the title update oidc.conf Update oidc.conf Dec 13, 2024
@pdabelf5 pdabelf5 added skip changelog Pull requests that don't need to be added to the changelog and removed bug An issue reporting a potential bug labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@jjngx jjngx jjngx approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Assignees
No one assigned
Labels
skip changelog Pull requests that don't need to be added to the changelog
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: v3.7.1 break the OIDC integration with Okta
5 participants
@vepatel @j1m-ryan @AlexFenlon @jjngx @pdabelf5