Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tech specs and regression k8s matrix #6316

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Aug 30, 2024

Proposed changes

  • remove versions older than 2 years from tech sepc,
  • update regression job to run tests on last 5 k8s version

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from a team as code owners August 30, 2024 11:32
@vepatel vepatel requested a review from shaun-nx August 30, 2024 11:32
@github-actions github-actions bot added documentation Pull requests/issues for documentation github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Aug 30, 2024
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6316/

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.03%. Comparing base (a41fc13) to head (7090858).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6316      +/-   ##
==========================================
+ Coverage   52.98%   53.03%   +0.04%     
==========================================
  Files          77       77              
  Lines       15900    15921      +21     
==========================================
+ Hits         8424     8443      +19     
  Misses       7071     7071              
- Partials      405      407       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ADubhlaoich ADubhlaoich added the needs cherry pick Cherry pick this PR into a release branch label Aug 30, 2024
@ADubhlaoich ADubhlaoich merged commit 06d875c into main Aug 30, 2024
52 of 54 checks passed
@ADubhlaoich ADubhlaoich deleted the chore/tech-spec-kind-regression branch August 30, 2024 13:00
nginx-bot pushed a commit that referenced this pull request Aug 30, 2024
- remove versions older than 2 years from tech specs
- update regression job to run tests on last 5 k8s version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation github_actions Pull requests that update Github_actions code needs cherry pick Cherry pick this PR into a release branch
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants