Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate NAP WAF v5 #5646

Closed
shaun-nx opened this issue May 29, 2024 · 1 comment · Fixed by #5698
Closed

Integrate NAP WAF v5 #5646

shaun-nx opened this issue May 29, 2024 · 1 comment · Fixed by #5698
Assignees
Labels
backlog Pull requests/issues that are backlog items proposal An issue that proposes a feature request
Milestone

Comments

@shaun-nx
Copy link
Contributor

shaun-nx commented May 29, 2024

As an engineer of the NGINX Ingress Controller, I would like to integrate NGINX AppProtect v5 so that we can continue to deliver the latest security features to our users.

This issue is a continuation of the POC effort to integrate NGINX AppProtect v5.
Details of that issue are captured here: #5483
Epic here: #5290

Relates issues:
Add NAP-WAF only support for debian 12 images

### UACs
- [x] Update Dockerfile to add build stages for NAP v5
- [x] Update codebase to work with both NAP v4 and NAP v5
- [x] Add Helm configuration options for NAP v5
- [x] Add UBI 8 and UBI 9 repo files to k8s-common repo
- [x] Update Debian build stages to use Debian 12
### Tasks
- [ ] Update [AppProtect Deployment](https://docs.nginx.com/nginx-ingress-controller/installation/integrations/app-protect-waf/installation/#deploy-ingress-controller) docs to change bundle path
- [x] Update Helm to allow PVC to be specified
- [ ] Write basic Python test(s) with bundles
- [ ] Update pipeline - build bundle(s) for testing
- [ ] Integration tests for NIC + WAF v5
- [ ] New docs on how to configure and deploy NIC with WAF v5
- [ ] Docker Scout tests + report
@shaun-nx shaun-nx added the proposal An issue that proposes a feature request label May 29, 2024
Copy link

Hi @shaun-nx thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@shaun-nx shaun-nx changed the title Support WAF v5 Support NAP WAF v5 May 29, 2024
@shaun-nx shaun-nx added the backlog Pull requests/issues that are backlog items label May 29, 2024
@shaun-nx shaun-nx added this to the v3.6.0 milestone May 29, 2024
@shaun-nx shaun-nx linked a pull request Jun 6, 2024 that will close this issue
6 tasks
@shaun-nx shaun-nx changed the title Support NAP WAF v5 Integrate NAP WAF v5 Jun 6, 2024
@shaun-nx shaun-nx mentioned this issue Jun 6, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Pull requests/issues that are backlog items proposal An issue that proposes a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants