Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC - Integrate NAP WAF v5.1 and v4.9 #5483

Closed
shaun-nx opened this issue May 1, 2024 · 2 comments
Closed

POC - Integrate NAP WAF v5.1 and v4.9 #5483

shaun-nx opened this issue May 1, 2024 · 2 comments
Assignees
Labels
backlog Pull requests/issues that are backlog items
Milestone

Comments

@shaun-nx
Copy link
Contributor

shaun-nx commented May 1, 2024

As a maintainer of the Ingress Controller, I would like to provide our users with support for NIC images with WAF v4.9 and v5.1

Definition of done:

  • NIC + WAF builds working with WAF v4.9 for Debian, Alpine and UBI 8 & 9
  • A path forward for how our NIC + WAF builds will operate with the additional waf-enforcer and waf-config-mgr containers.

For integration test with WAF v4.9, we've made a PR to allow our pipeline to run the tests: #5498

### v4.9 Deployment test
- [x] NIC with WAF v4.9 for Debian
- [x] NIC with WAF v4.9 for Alpine
- [x] NIC with WAF v4.9 for UBI 9(RedHat)
### v5.1 Deployment test
- [x] Build NIC with WAF v5 for Debian
- [x] Update NGINX Template to add `app_protect_enforcer_address` [docs reference](https://docs.nginx.com/nginx-app-protect-waf/v5/admin-guide/deploy-on-kubernetes/#nginx-configuration)
- [x] Deploy NIC with WAF v5 + waf-enforcer and waf-config-mgr containers
Copy link

github-actions bot commented May 1, 2024

Hi @shaun-nx thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@shaun-nx shaun-nx added the backlog Pull requests/issues that are backlog items label May 1, 2024
@shaun-nx shaun-nx added this to the v3.6.0 milestone May 1, 2024
@shaun-nx shaun-nx changed the title POC - Support NAP WAF v5.1 & v4.9 POC - Support NAP WAF v5.1 and v4.9 May 1, 2024
@shaun-nx shaun-nx changed the title POC - Support NAP WAF v5.1 and v4.9 POC - Integrate NAP WAF v5.1 and v4.9 May 1, 2024
@shaun-nx
Copy link
Contributor Author

shaun-nx commented May 3, 2024

v4.9 POC branch: https://github.com/nginxinc/kubernetes-ingress/tree/poc/waf-v4.9

@shaun-nx shaun-nx linked a pull request May 29, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Pull requests/issues that are backlog items
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants