Fix 15 #16
Merged
Fix 15 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elijah Zupancic <[email protected]>
Signed-off-by: Elijah Zupancic <[email protected]>
Executing gunicorn by bash script gives us more flexibility in how it is invoked. We can set default values for log level, etc. Moreover, in this change we are defining a default Docker CMD in the python base image so that this does not need to be defined in each inherited image. Signed-off-by: Elijah Zupancic <[email protected]>
Signed-off-by: Elijah Zupancic <[email protected]>
This change fixes the issue where JWT validation was failing when adding money or doing payments. In order to fix the issue, the JWT authentication logic needed to be refactored. Additionally, due to the previous commit that upgraded the Mockito dependencies, the mocking logic needed to be modified. Signed-off-by: Elijah Zupancic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change fixes #15. It also incorporates a number of small improvements in debugging and structure that made debugging the root cause of the issue easier.
Checklist
Before creating a PR, run through this checklist and mark each as complete.