Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault when receiving the traceparent header and otel is not configured #1523

Closed
psdesse-vivlio opened this issue Dec 26, 2024 · 1 comment · Fixed by #1531
Closed

Segfault when receiving the traceparent header and otel is not configured #1523

psdesse-vivlio opened this issue Dec 26, 2024 · 1 comment · Fixed by #1531
Assignees

Comments

@psdesse-vivlio
Copy link

We have encountered this problem with Nginx Unit after upgrading to 1.34. Our setup is:

  • No otel configuration block in Nginx Unit configuration;
  • Our system has tracing enable on some other components of the system, this result in a traceparent header being present on the request.

In this case, the router of Nginx Unit segfault every time when receiving the request. This seems to be due to a missing check on whereas the otel structure is initialized in nxt_otel_parse_traceparent (not verified but probably too in nxt_otel_parse_tracestate).

We will test, as a workaround, to configure otel in Nginx Unit which should make the problem disappear.

@psdesse-vivlio
Copy link
Author

We will test, as a workaround, to configure otel in Nginx Unit which should make the problem disappear.

I confirm that configuring otel in the settings get rid of the problem.

avahahn added a commit to avahahn/unit that referenced this issue Jan 7, 2025
This commit adds NULL checks for the request->otel object that
were missed in the Traceparent and Tracestate routines.

Closes: nginx#1523
Closes: nginx#1526
Fixes: 9d3dcb8 ("otel: add build tooling to include otel code")
Signed-off-by: Ava Hahn <[email protected]>
@avahahn avahahn closed this as completed in d699fb9 Jan 8, 2025
@callahad callahad marked this as a duplicate of #1535 Jan 10, 2025
ac000 pushed a commit to ac000/unit that referenced this issue Jan 10, 2025
This commit adds NULL checks for the request->otel object that
were missed in the Traceparent and Tracestate routines.

Closes: nginx#1523
Closes: nginx#1526
Fixes: 9d3dcb8 ("otel: add build tooling to include otel code")
Signed-off-by: Ava Hahn <[email protected]>
thresheek pushed a commit that referenced this issue Jan 10, 2025
This commit adds NULL checks for the request->otel object that
were missed in the Traceparent and Tracestate routines.

Closes: #1523
Closes: #1526
Fixes: 9d3dcb8 ("otel: add build tooling to include otel code")
Signed-off-by: Ava Hahn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants