feat: (2 of 2) Upstream module example #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanitskiy
reviewed
Jul 6, 2023
ivanitskiy
reviewed
Jul 6, 2023
| } | ||
| let hccf = maybe_conf.unwrap(); | ||
| // NOTE: ngx_conf_init_uint_value macro is unavailable | ||
| if (*hccf).max == u32::MAX { |
There was a problem hiding this comment.
nit: may be do a dereference here and then you don't need to do (*hccf)/(*us)?
There was a problem hiding this comment.
are you suggesting something like:
let hccf = *(maybe_conf.unwrap());
or something different that i'm not understanding?
There was a problem hiding this comment.
i was looking at the Deref trait, but doesn't seem appropriate here unless i'm missing something more.
added 2 commits
September 1, 2023 12:10
Upstream example - derived from github.com/gabihodoroaga/nginx-upstream-module and NGINX ngx_http_upstream_keepalive_module.c Simply replaces peer functions with passthrough versions, i.e., proxies traffic through this module to originally configured upstream functions. Useful as a guide and example, but does not add load balancing algorithms.
f5yacobucci
force-pushed
the
issue-30-upstream
branch
from
4e98614 to
8081f84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream example
Simply replaces peer functions with passthrough versions, i.e., proxies
traffic through this module to originally configured upstream functions.
Useful as a guide and example, but does not add load balancing
algorithms.
Fixes #30 (replaces PR #35)
Checklist
Before creating a PR, run through this checklist and mark each as complete.