-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Helm Chart to install NKG #840
Conversation
We still need to refine it, but being that this work and #798 are slated for 0.6.0, I wonder if we get the latter done first so that we don't need the njs configmap in our helm chart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we also update the main README?
@sjberman I think the work can coexist for now - if #798 gets done first, we can simplify the Helm chart as part of this work. If not, we can do it as part of that one. |
c561ee0
to
27d7ecf
Compare
The main reason I bring it up is that if we get helm charts released into 0.5, then we break the chart in 0.6 when we change containers up. Not a huge deal since we're still pre-v1, but avoiding breaking changes is nice. |
af55b00
to
e4ba68a
Compare
9478919
to
92e048d
Compare
92e048d
to
471bda4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you update the PR description to follow problem/solution template and make sure there is a commit with problem/statement? (according to our guidelines)
ae2598f
to
aa26c88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
16db9c9
to
0825933
Compare
for more information, see https://pre-commit.ci
86720b9
to
ca194bf
Compare
Add a Helm chart to install NKG
Proposed changes
Problem:
As a potential user of NKG
I want to use a Helm chart to install the NGINX Kubernetes Gateway
So that I can use one command to install the NGINX Kubernetes Gateway
And so that I can easily update.
Solution:
Testing: Local testing - verified local basic installation and modifications to the default values
Closes #614
Checklist
Before creating a PR, run through this checklist and mark each as complete.