Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenAPI CRD schema validation #868

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Add OpenAPI CRD schema validation #868

merged 2 commits into from
Mar 5, 2020

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • Added client side validation for creation or modification of VS/VSR CRDs.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Mar 4, 2020
@Dean-Coakley Dean-Coakley self-assigned this Mar 4, 2020
@Dean-Coakley Dean-Coakley force-pushed the add-schema-validation branch from b5e4e47 to a1b7b2b Compare March 4, 2020 11:28
@Dean-Coakley Dean-Coakley force-pushed the add-schema-validation branch from a1b7b2b to a75f998 Compare March 4, 2020 12:04
@Dean-Coakley Dean-Coakley force-pushed the add-schema-validation branch from a75f998 to d0acb21 Compare March 4, 2020 16:20
@Dean-Coakley Dean-Coakley requested a review from tellet March 4, 2020 16:29
pleshakov
pleshakov approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Rulox
Rulox approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, :shipit:

json:",inline" whas the key! 😂

@Dean-Coakley Dean-Coakley merged commit 406404c into master Mar 5, 2020
@Dean-Coakley Dean-Coakley deleted the add-schema-validation branch March 5, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rulox Rulox Rulox approved these changes

@pleshakov pleshakov pleshakov approved these changes

@lucacome lucacome Awaiting requested review from lucacome

@tellet tellet Awaiting requested review from tellet

Assignees

@Dean-Coakley Dean-Coakley

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @pleshakov @Rulox