Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add session persistence in VS/VSR #728

Merged
merged 6 commits into from
Oct 22, 2019
Merged

Add session persistence in VS/VSR #728

merged 6 commits into from
Oct 22, 2019

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

Add session persistence to Upstreams in VirtualServers.

See https://nginx.org/en/docs/http/ngx_http_upstream_module.html?#sticky for more details
Requires NGINX Plus.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Oct 18, 2019
@Dean-Coakley Dean-Coakley self-assigned this Oct 18, 2019
pleshakov
pleshakov suggested changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dean-Coakley thanks. please see my suggestions

docs/virtualserver-and-virtualserverroute.md Show resolved Hide resolved
internal/configs/version2/config.go Outdated Show resolved Hide resolved
internal/configs/version2/nginx-plus.virtualserver.tmpl Outdated Show resolved Hide resolved
internal/configs/virtualserver_test.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
Rulox
Rulox approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, a few suggestions, feel free to implement/discuss them. Thanks!

docs/virtualserver-and-virtualserverroute.md Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Show resolved Hide resolved
pleshakov
pleshakov approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dean-Coakley Dean-Coakley merged commit a9a825e into master Oct 22, 2019
@Dean-Coakley Dean-Coakley deleted the vs-session-persist branch October 22, 2019 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rulox Rulox Rulox approved these changes

@pleshakov pleshakov pleshakov approved these changes

@bvighnesha bvighnesha Awaiting requested review from bvighnesha

@ampant ampant Awaiting requested review from ampant

Assignees

@Dean-Coakley Dean-Coakley

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @pleshakov @Rulox