-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run IC as non-root #710
Run IC as non-root #710
Conversation
Checking CI :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rulox thanks. please see my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Proposed changes
Closes #529
This PR makes the changes in all the Dockerfiles (and IC code) to run IC and NGINX as non root.
Changes are:
nginx
as user instead of rootnginx
userpid
, opentracing config and unixsockets
to/var/lib/nginx
setcap
so we can still use ports 80 and 443 without being rootuser
directive in NGINX conf (not needed anymore as we are running NGINX asnginx
user)PS: I have arranged the Dockerfiles to keep consistency (order, number of layers, etc).
Thanks to @LorcanMcVeigh as he started working on this.