Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update secrets when mgmt configmap changes #6947

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Dec 10, 2024

Proposed changes

  • ensure to write secrets when mgmt config map changes
  • write python test to validate change

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner December 10, 2024 09:19
@github-actions github-actions bot added go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests labels Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.

Project coverage is 52.59%. Comparing base (8e28c37) to head (a65d402).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/controller.go 0.00% 47 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6947      +/-   ##
==========================================
- Coverage   52.64%   52.59%   -0.06%     
==========================================
  Files          88       88              
  Lines       20758    20789      +31     
==========================================
+ Hits        10929    10933       +4     
- Misses       9372     9401      +29     
+ Partials      457      455       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 requested review from jjngx and j1m-ryan December 10, 2024 13:07
@danielnginx danielnginx requested a review from a team December 10, 2024 13:19
internal/k8s/controller.go Outdated Show resolved Hide resolved
@danielnginx danielnginx requested a review from a team December 10, 2024 13:20
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀, left one comment

@pdabelf5 pdabelf5 merged commit 15403da into main Dec 10, 2024
81 checks passed
@pdabelf5 pdabelf5 deleted the mgmt-config-map-pytest branch December 10, 2024 14:44
@pdabelf5 pdabelf5 added chore Pull requests for routine tasks and removed go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants