Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to usage-reporting page #6899

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Dec 3, 2024

Proposed changes

  • Update usage-reporting page

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from a team as code owners December 3, 2024 15:55
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6899/

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.15%. Comparing base (97055e4) to head (60dec94).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6899   +/-   ##
=======================================
  Coverage   53.15%   53.15%           
=======================================
  Files          88       88           
  Lines       20396    20396           
=======================================
  Hits        10842    10842           
  Misses       9111     9111           
  Partials      443      443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small phrasing suggestion, otherwise LGTM.

site/content/usage-reporting.md Outdated Show resolved Hide resolved
@ADubhlaoich ADubhlaoich added the needs cherry pick Cherry pick this PR into a release branch label Dec 3, 2024
Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Venktesh Shivam Patel <[email protected]>
@vepatel vepatel enabled auto-merge (squash) December 3, 2024 16:30
@vepatel vepatel merged commit 9f3157a into main Dec 3, 2024
30 checks passed
@vepatel vepatel deleted the docs/update-usage-reportin-doc branch December 3, 2024 16:33
nginx-bot pushed a commit that referenced this pull request Dec 3, 2024
@pdabelf5 pdabelf5 changed the title update usage-reporting Updates to usage-reporting page Dec 16, 2024
@pdabelf5 pdabelf5 removed the needs cherry pick Cherry pick this PR into a release branch label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

5 participants