Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor configmap.go for extensability #6873

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

j1m-ryan
Copy link
Contributor

@j1m-ryan j1m-ryan commented Nov 27, 2024

Proposed changes

refactor configmap.go, preparing for mgmt configmap

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested a review from a team as a code owner November 27, 2024 12:00
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 53.24%. Comparing base (729570c) to head (5db33d7).
Report is 58 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/configmap.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6873      +/-   ##
==========================================
+ Coverage   53.23%   53.24%   +0.01%     
==========================================
  Files          88       88              
  Lines       20354    20363       +9     
==========================================
+ Hits        10835    10842       +7     
- Misses       9074     9078       +4     
+ Partials      445      443       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j1m-ryan j1m-ryan enabled auto-merge (squash) November 27, 2024 16:20
@j1m-ryan j1m-ryan merged commit 8b8fc52 into main Nov 27, 2024
82 checks passed
@j1m-ryan j1m-ryan deleted the chore/refactor-configmap-go branch November 27, 2024 17:07
@pdabelf5 pdabelf5 added chore Pull requests for routine tasks and removed go Pull requests that update Go code labels Dec 16, 2024
@pdabelf5 pdabelf5 changed the title refactor configmap.go for extensability Refactor configmap.go for extensability Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants