Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build UBI s390x nginx package for OSS images #6846

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Build UBI s390x nginx package for OSS images #6846

merged 4 commits into from
Nov 22, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Nov 22, 2024 •
edited
Loading

Proposed changes

Similar to PPC64LE architectures, we now need to build s390x packages for UBI images.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner November 22, 2024 09:17
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code chore Pull requests for routine tasks labels Nov 22, 2024
@pdabelf5 pdabelf5 self-assigned this Nov 22, 2024
@pdabelf5 pdabelf5 added the needs cherry pick Cherry pick this PR into a release branch label Nov 22, 2024
@pdabelf5 pdabelf5 enabled auto-merge (squash) November 22, 2024 10:10
@pdabelf5 pdabelf5 merged commit cab70d7 into main Nov 22, 2024
79 checks passed
@pdabelf5 pdabelf5 deleted the s390x branch November 22, 2024 10:14
nginx-bot pushed a commit that referenced this pull request Nov 22, 2024
@pdabelf5 @web-flow
build UBI s390x nginx package for OSS images (#6846)
52338b7
@pdabelf5 pdabelf5 changed the title build UBI s390x nginx package for OSS images Build UBI s390x nginx package for OSS images Dec 16, 2024
@pdabelf5 pdabelf5 removed github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code needs cherry pick Cherry pick this PR into a release branch labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@vepatel vepatel vepatel approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Assignees

@pdabelf5 pdabelf5

Labels
chore Pull requests for routine tasks
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pdabelf5 @j1m-ryan @vepatel @AlexFenlon @jjngx