Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor secret name for clarity #6823

Merged
merged 2 commits into from
Nov 19, 2024
Merged

refactor secret name for clarity #6823

merged 2 commits into from
Nov 19, 2024

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Nov 19, 2024 •
edited
Loading

Proposed changes

  • Small refactor of some secret file names to have better clarity of what the const is
  • Refactor of secrExists to secretWatched to make that clearer to what it does

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner November 19, 2024 13:03
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 19, 2024
@AlexFenlon AlexFenlon merged commit 3ca3d6e into main Nov 19, 2024
79 checks passed
@AlexFenlon AlexFenlon deleted the secret-filename-refactor branch November 19, 2024 15:57
@pdabelf5 pdabelf5 added the skip changelog Pull requests that don't need to be added to the changelog label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@vepatel vepatel vepatel approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code skip changelog Pull requests that don't need to be added to the changelog
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexFenlon @j1m-ryan @vepatel @jjngx @pdabelf5