-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Makefile Bug #6809
Fix Makefile Bug #6809
Conversation
Signed-off-by: Saed SayedAhmed <[email protected]>
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
recheck |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6809 +/- ##
=======================================
Coverage 53.45% 53.45%
=======================================
Files 88 88
Lines 20211 20211
=======================================
Hits 10803 10803
Misses 8964 8964
Partials 444 444 ☔ View full report in Codecov by Sentry. |
Proposed changes
If you checkout anything but the latest git tag,
make
withTARGET=download
will fail becausehack/docker.sh
will returnfail
becauseGIT_TAG
always returns the latest tag despite it not necessarily being checked-out.This is the error it will return for example if you checkout
v3.7.0
(the latest tag isv3.7.1
and runmake debian-image-nap-v5-plus PREFIX=local_image TARGET=download NGINX_AGENT=true TAG=current
:Checklist
Before creating a PR, run through this checklist and mark each as complete.