Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Makefile Bug #6809

Merged
merged 8 commits into from
Dec 10, 2024
Merged

Fix Makefile Bug #6809

merged 8 commits into from
Dec 10, 2024

Conversation

saedx1
Copy link
Contributor

@saedx1 saedx1 commented Nov 14, 2024

Proposed changes

If you checkout anything but the latest git tag, make with TARGET=download will fail because hack/docker.sh will return fail because GIT_TAG always returns the latest tag despite it not necessarily being checked-out.

This is the error it will return for example if you checkout v3.7.0 (the latest tag is v3.7.1 and run make debian-image-nap-v5-plus PREFIX=local_image TARGET=download NGINX_AGENT=true TAG=current:

Makefile:124: *** unable to build with TARGET=download, this function is only available when building from a git tag or from the latest commit matching the edge image.  Stop.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mrexox Valentin Kiselev
Signed-off-by: Saed SayedAhmed <[email protected]>
@saedx1 saedx1 requested a review from a team as a code owner November 14, 2024 13:36
Copy link

github-actions bot commented Nov 14, 2024

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 14, 2024
@saedx1
Copy link
Contributor Author

saedx1 commented Nov 14, 2024

I have hereby read the F5 CLA and agree to its terms

@saedx1
Copy link
Contributor Author

saedx1 commented Nov 14, 2024

recheck

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mrexox Valentin Kiselev
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (0db9f89) to head (b1386e2).
Report is 54 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6809   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files          88       88           
  Lines       20211    20211           
=======================================
  Hits        10803    10803           
  Misses       8964     8964           
  Partials      444      444           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mrexox Valentin Kiselev
jjngx and others added 5 commits December 6, 2024 17:23
@pdabelf5 pdabelf5 merged commit 025ddd7 into nginx:main Dec 10, 2024
113 of 133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants