Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NMS references #6802

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Update NMS references #6802

merged 5 commits into from
Nov 18, 2024
+34 −34

Conversation

Jcahilltorre
Copy link
Contributor

@Jcahilltorre Jcahilltorre commented Nov 13, 2024 •
edited
Loading

Proposed changes

Replaces NMS mentions with their NIM equivalents.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@Jcahilltorre Jcahilltorre requested review from a team as code owners November 13, 2024 14:34
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Nov 13, 2024
@Jcahilltorre Jcahilltorre self-assigned this Nov 13, 2024
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6802/

@ADubhlaoich ADubhlaoich added the needs cherry pick Cherry pick this PR into a release branch label Nov 13, 2024
@Jcahilltorre Jcahilltorre enabled auto-merge (squash) November 18, 2024 14:25
@Jcahilltorre Jcahilltorre merged commit 582198a into main Nov 18, 2024
30 checks passed
@Jcahilltorre Jcahilltorre deleted the fix-nms-mentions branch November 18, 2024 14:46
nginx-bot pushed a commit that referenced this pull request Nov 18, 2024
@Jcahilltorre @web-flow
docs: update NMS references (#6802)
7c935be 
* docs: update NMS references

* docx: fix additional link

* docs: remove further NMS mentions

* docs: add nim requirements
ADubhlaoich pushed a commit that referenced this pull request Nov 19, 2024
@nginx-bot @Jcahilltorre
[cherry-pick] docs: update NMS references (#6820)
eef3176 
docs: update NMS references (#6802)

* docs: update NMS references

* docx: fix additional link

* docs: remove further NMS mentions

* docs: add nim requirements

Co-authored-by: Jon Torre <[email protected]>
@pdabelf5 pdabelf5 changed the title docs: update NMS references Update NMS references Dec 16, 2024
@pdabelf5 pdabelf5 removed the needs cherry pick Cherry pick this PR into a release branch label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@nginx-aoife nginx-aoife nginx-aoife approved these changes

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

Assignees

@Jcahilltorre Jcahilltorre

Labels
documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jcahilltorre @ADubhlaoich @nginx-aoife @vepatel @pdabelf5