Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate v1alpha1 CRDs for GlobalConfiguration, Policy & TransportServer #6800

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Nov 13, 2024

Proposed changes

Deprecate the v1alpha1 crds for GlobalConfiguration, Policy & TransportServer

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner November 13, 2024 11:21
@github-actions github-actions bot added documentation Pull requests/issues for documentation go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests labels Nov 13, 2024
@pdabelf5 pdabelf5 changed the title deprecated v1alpha1 CRDs for GlobalConfiguration, Policy & TransportServer Draft: deprecated v1alpha1 CRDs for GlobalConfiguration, Policy & TransportServer Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (214d9f1) to head (3417684).
Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6800      +/-   ##
==========================================
- Coverage   53.46%   53.45%   -0.02%     
==========================================
  Files          89       88       -1     
  Lines       20218    20205      -13     
==========================================
- Hits        10809    10800       -9     
+ Misses       8965     8961       -4     
  Partials      444      444              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 changed the title Draft: deprecated v1alpha1 CRDs for GlobalConfiguration, Policy & TransportServer Draft: deprecate v1alpha1 CRDs for GlobalConfiguration, Policy & TransportServer Nov 13, 2024
@pdabelf5 pdabelf5 changed the title Draft: deprecate v1alpha1 CRDs for GlobalConfiguration, Policy & TransportServer Deprecate v1alpha1 CRDs for GlobalConfiguration, Policy & TransportServer Nov 13, 2024
@pdabelf5 pdabelf5 enabled auto-merge (squash) November 14, 2024 09:23
@pdabelf5 pdabelf5 merged commit 426716b into main Nov 14, 2024
81 checks passed
@pdabelf5 pdabelf5 deleted the deprecate-v1alpha1-crds branch November 14, 2024 09:58
@pdabelf5 pdabelf5 added change Pull requests that introduce a change and removed documentation Pull requests/issues for documentation go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Pull requests that introduce a change
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants