Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add buffering support for vs/vsr #670

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Add buffering support for vs/vsr #670

merged 1 commit into from
Sep 4, 2019

Conversation

ampant
Copy link
Contributor

@ampant ampant commented Aug 22, 2019 •
edited
Loading

Proposed changes

Added support for configuring buffering in upstream of vs/vsr.

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@ampant ampant added the enhancement Pull requests for new features/feature enhancements label Aug 22, 2019
@ampant ampant requested a review from bvighnesha August 22, 2019 08:21
Dean-Coakley
Dean-Coakley suggested changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of comments.

docs/virtualserver-and-virtualserverroute.md Outdated Show resolved Hide resolved
docs/virtualserver-and-virtualserverroute.md Outdated Show resolved Hide resolved
docs/virtualserver-and-virtualserverroute.md Outdated Show resolved Hide resolved
pkg/apis/configuration/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/apis/configuration/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/apis/configuration/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
@ampant ampant self-assigned this Aug 22, 2019
@ampant ampant requested a review from Dean-Coakley August 22, 2019 11:41
pleshakov
pleshakov suggested changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ampant thx for the PR. please see some suggestions.

Additinoally, as as Dean mentioned #670 (comment), Buffers warrents an entry into docs similar to: https://github.com/nginxinc/kubernetes-ingress/blob/master/docs/virtualserver-and-virtualserverroute.md#upstreamtls

I suggest renaming Add Configure buffering support for vs/vsr to Add buffering support for vs/vsr for simplicity

pkg/apis/configuration/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
internal/configs/virtualserver.go Outdated Show resolved Hide resolved
@ampant ampant changed the title Add Configure buffering support for vs/vsr Add buffering support for vs/vsr for simplicity Aug 23, 2019
@ampant ampant changed the title Add buffering support for vs/vsr for simplicity Add buffering support for vs/vsr Aug 23, 2019
@ampant ampant force-pushed the feature/buffer branch 5 times, most recently from ae1bc25 to 6f54aec Compare August 23, 2019 09:20
pleshakov
pleshakov suggested changes Aug 24, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ampant thx. please see my suggestions

docs/virtualserver-and-virtualserverroute.md Outdated Show resolved Hide resolved
docs/virtualserver-and-virtualserverroute.md Show resolved Hide resolved
docs/virtualserver-and-virtualserverroute.md Show resolved Hide resolved
pkg/apis/configuration/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation_test.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation_test.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation_test.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation_test.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation_test.go Outdated Show resolved Hide resolved
@ampant ampant force-pushed the feature/buffer branch 3 times, most recently from c74482e to f480363 Compare August 26, 2019 06:37
@ampant ampant requested a review from pleshakov August 27, 2019 05:49
pleshakov
pleshakov suggested changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ampant thx! Please see my comments

docs/virtualserver-and-virtualserverroute.md Outdated Show resolved Hide resolved
docs/virtualserver-and-virtualserverroute.md Show resolved Hide resolved
docs/virtualserver-and-virtualserverroute.md Show resolved Hide resolved
docs/virtualserver-and-virtualserverroute.md Outdated Show resolved Hide resolved
docs/virtualserver-and-virtualserverroute.md Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation_test.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation_test.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
@ampant ampant force-pushed the feature/buffer branch 3 times, most recently from c28537c to c7e6e9b Compare August 29, 2019 05:55
@pleshakov
Copy link
Contributor

@ampant thx for the updates. the changes look good!

I agree with @Rulox suggestions.

Please also rebase against the master so that the conflict is resolved.

@ampant ampant force-pushed the feature/buffer branch 2 times, most recently from e8adff8 to cfd9926 Compare August 30, 2019 05:44
pleshakov
pleshakov approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ampant thx! approving. please implement the suggestion before merging.

pkg/apis/configuration/validation/validation_test.go Show resolved Hide resolved
@ampant ampant requested a review from Rulox September 1, 2019 07:19
Rulox
Rulox approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

@ampant Please make sure you resolve/update all the pending suggestions before merging. And remember to use Rebase and merge when merging the PR.

Thanks!

@ampant ampant merged commit 4c6e9c8 into master Sep 4, 2019
@ampant ampant deleted the feature/buffer branch September 5, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rulox Rulox Rulox approved these changes

@pleshakov pleshakov pleshakov approved these changes

@bvighnesha bvighnesha Awaiting requested review from bvighnesha

@Dean-Coakley Dean-Coakley Awaiting requested review from Dean-Coakley

Assignees

@ampant ampant

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ampant @pleshakov @Rulox @Dean-Coakley